Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render commas between enum values. #1240

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Render commas between enum values. #1240

merged 1 commit into from
Sep 21, 2022

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Sep 16, 2022 •
edited by github-actions bot
Loading

@clokep clokep mentioned this pull request Sep 16, 2022
Merged
@clokep
Copy link
Contributor Author

clokep commented Sep 16, 2022

Compare:

Original This PR
image image

@clokep clokep marked this pull request as ready for review September 16, 2022 13:07
@clokep clokep requested a review from a team as a code owner September 16, 2022 13:07
uhoreg
uhoreg approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do what it claims to do

@uhoreg uhoreg merged commit bd4593f into matrix-org:main Sep 21, 2022
@clokep clokep deleted the enum-commas branch September 21, 2022 13:28
@zecakeh zecakeh mentioned this pull request Sep 22, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clokep @uhoreg